Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on SSH connection for incorrect configuration (#19317) #19437

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 20, 2022

Backport #19317

  • Warn on SSH connection for incorrect configuration
  • When setting.RepoRootPath cannot be found(most likely due to
    incorrect configuration) show "Gitea: Incorrect configuration" on the
    client-side to help easier with debugging the problem.

Co-authored-by: delvh [email protected]
Co-authored-by: wxiaoguang [email protected]
Co-authored-by: techknowlogick [email protected]

* Warn on SSH connection for incorrect configuration

- When `setting.RepoRootPath` cannot be found(most likely due to
incorrect configuration) show "Gitea: Incorrect configuration" on the
client-side to help easier with debugging the problem.

* Update cmd/serv.go

Co-authored-by: delvh <[email protected]>

* Don't leak configuration

* Update cmd/serv.go

Co-authored-by: delvh <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@6543 6543 added the type/enhancement An improvement of existing functionality label Apr 20, 2022
@6543 6543 added this to the 1.16.6 milestone Apr 20, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2022
@6543
Copy link
Member Author

6543 commented Apr 20, 2022

🚀

@6543 6543 merged commit 6bddfd3 into go-gitea:release/v1.16 Apr 20, 2022
@6543 6543 deleted the backport_19317 branch April 20, 2022 17:18
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants